[Bug]: Duplicate Custommodeldata value

[ghost]

Conversion Issue Link

https://github.com/Kas-tle/java2bedrock.sh/issues/59

Expected Output

Because the custommodeldata value of different items may be the same, and they are named according to the converted item id, it is easy to cause the item to be named the same. It is recommended to add the original item name to the converted item id for example: gmdl_114514 (original) => gmdl_iron_sword_114514 (workaround)

Actual Output

/

Additional Context

i use machine translate

[Kas-tle]

Hello, the number after the item has nothing to do with the actual custom model data value. All items are simply numbered which all instances of predicate overrides are found. Furthermore, in the conversion run you link has not even finished, so I am not sure why you already expect there to be duplicate names.

[ghost]

I tested it in local before, but some icons in this pack will be ignored

[ghost]

Hello, the number after the item has nothing to do with the actual custom model data value. All items are simply numbered which all instances of predicate overrides are found. Furthermore, in the conversion run you link has not even finished, so I am not sure why you already expect there to be duplicate names.

like this

[ghost]

Hello, the number after the item has nothing to do with the actual custom model data value. All items are simply numbered which all instances of predicate overrides are found. Furthermore, in the conversion run you link has not even finished, so I am not sure why you already expect there to be duplicate names.

[Kas-tle]

The icon issue there has nothing to do with a duplicate identifier. It is because the converter sets the item as the vanilla icon. However, it uses the java names. Bedrock in most, but not all cases, uses the same icon names. I suppose I should make clearer in the readme that this is a limitation. You would need to make your own sprite icon for each item if you wanted them to look correct anyways, as bedrock has no way of generating the 2D inventory icon from the 3D model as java does.

[ghost]

The icon issue there has nothing to do with a duplicate identifier. It is because the converter sets the item as the vanilla icon. However, it uses the java names. Bedrock in most, but not all cases, uses the same icon names. I suppose I should make clearer in the readme that this is a limitation. You would need to make your own sprite icon for each item if you wanted them to look correct anyways, as bedrock has no way of generating the 2D inventory icon from the 3D model as java does.

well, my fault, thanks a lot anyway