Open github-actions[bot] opened 1 year ago
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍 Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!
ed25519-dalek
1.0.1
>=2
Versions of
ed25519-dalek
prior to v2.0 model private and public keys as separate types which can be assembled into aKeypair
, and also provide APIs for serializing and deserializing 64-byte private/public keypairs.Such APIs and serializations are inherently unsafe as the public key is one of the inputs used in the deterministic computation of the
S
part of the signature, but not in theR
value. An adversary could somehow use the signing function as an oracle that allows arbitrary public keys as input can obtain two signatures for the same message sharing the sameR
and only differ on theS
part.Unfortunately, when this happens, one can easily extract the private key.
Revised public APIs in v2.0 of
ed25519-dalek
do NOT allow a decoupled private/public keypair as signing input, except as part of specially labeled "hazmat" APIs which are clearly labeled as being dangerous if misused.See advisory page for additional details.