search

KasemJaffer / receive_sharing_intent

A Flutter plugin that enables flutter apps to receive sharing photos, text and url from other apps.
Apache License 2.0
334 stars 391 forks source link

fix kotlin build problem #137

Closed LazyDave76 closed 3 years ago

LazyDave76 commented 3 years ago

Build fails for android because of nullability.

LazyDave76 commented 3 years ago

included https://github.com/KasemJaffer/receive_sharing_intent/pull/140

KasemJaffer commented 3 years ago

Fixed in later versions

proninyaroslav commented 3 years ago

@KasemJaffer No. 1.4.4 also crashes on build, the @LazyDave76 version doesn't have this problem:

e: /home/yaroslav/.pub-cache/hosted/pub.dartlang.org/receive_sharing_intent-1.4.4/android/src/main/kotlin/com/kasem/receive_sharing_intent/ReceiveSharingIntentPlugin.kt: (146, 78): Type mismatch: inferred type is Uri? but Uri was expected
e: /home/yaroslav/.pub-cache/hosted/pub.dartlang.org/receive_sharing_intent-1.4.4/android/src/main/kotlin/com/kasem/receive_sharing_intent/ReceiveSharingIntentPlugin.kt: (207, 95): Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type String?
kaboc commented 3 years ago

@KasemJaffer The issue still exists. I think the changes by @LazyDave76 should be reviewed and merged. It doesn't look nice that you just closed this issue without respecting his contribution.

LazyDave76 commented 3 years ago

@KasemJaffer The issue still exists. I think the changes by @LazyDave76 should be reviewed and merged. It doesn't look nice that you just closed this issue without respecting his contribution.

Thanks for the support @kaboc :) I was surprised to see it closed too - I fixed bugs in iOS and Android.

@proninyaroslav copied and opened the pull request https://github.com/KasemJaffer/receive_sharing_intent/pull/145 maybe that one will be approved.

gerken-tss commented 2 years ago

@KasemJaffer This is still an issue! Please merge this!