search

Kaspa-maker / formula1-app

Web app development assignment 1
0 stars 1 forks source link

Feedback #1

Open diarmuidoconnor opened 4 years ago

diarmuidoconnor commented 4 years ago

As your README is incomplete (screenshots of views/pages missing) I am unable to assess this project - rectify immediately. From drilling into your components, you seem to be hard-coding your data inside components.

You need to implement (some of) the following to warrant a good grade:

Kaspa-maker commented 4 years ago

Hello Diarmuid I just wanted to inform you that those tabs for drivers and tracks are meant to be hard coded they are not meant to be added the only adding, deleting that is meant to be done in the app is in the info/news section. The point of the tracks tab and drivers tab is to show the user of what drivers are on the grid and what tracks are in Formula 1. The only part were the user is allowed to enter something is with the news tab were they can post rumours.

pt., 15 lis 2019 o 12:43 Diarmuid O Connor notifications@github.com napisał(a):

As your README is incomplete (screenshots of views/pages missing) I am unable to assess this project - rectify immediately. From drilling into your components, you seem to be hard-coding your data inside components.

You need to implement (some of) the following to warrant a good grade:

  • Extract data out to a datastore, either stub API or JSON server
  • Add a view to allow the user add a new driver/track.
  • Ability to delete a driver/track

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Kaspa-maker/formula1-app/issues/1?email_source=notifications&email_token=ANGJCRFAES7UFL6J33BTUMDQT2KNZA5CNFSM4JN2JS52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HZTGSTQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANGJCRF5UJIP7VCCVBJ7F63QT2KNZANCNFSM4JN2JS5Q .

Kaspa-maker commented 4 years ago

I have added changes to the readme file and made the adding and removing in the info/news tab were it is meant to take place.

diarmuidoconnor commented 4 years ago

My advice to you above is motivated by the fact your submission is inadequate for a clear pass grade based on the published grading spectrum. The spectrum attempts to measures the students level of understanding of the React framework. The app is meant to be prototype standard. A production version would probably have authentication for users and administrators - only the administrator would be allowed add/remove drivers/tracks.

You are free to ignore my advice or adapt it to your own opinions, which may or may not be meet the spectrum requirements.

Hope this make sense.

[Feel free to continue the discussion in the labs]

diarmuidoconnor commented 4 years ago

I have reviewed your assignment 1 submission. Based on the published marking scheme I am provisionally awarding a mark of 46%. This mark is subject to you being able to demonstrate the app and clearly answering any question about its implementation (Demos will be scheduled in week 13).

Based on the grading scheme published, the breakdown of the overall mark is: Good 40 Excellent 6 Outstanding 0

The design/structure of the codebase submitted seems to reflect a misunderstanding of some fundamental aspects of React and SPAs, e.g. components, as well as the difference between a static website and dynamic web app.

Feel free to discuss these points at the lab classes.

This thread is now closed.