search

KasparEtter / ef1p

Explained from First Principles is a technology, science, and philosophy blog for curious people who want to understand and change the world.
https://explained-from-first-principles.com
Creative Commons Attribution 4.0 International
117 stars 5 forks source link

Update number-theory.md #8

Closed skaunov closed 1 year ago

skaunov commented 1 year ago

Correct quantity in #visualization-of-cosets caption.

Pls, review this one, it seems to me, that there should be three disjoint cosets.

KasparEtter commented 1 year ago

Hi, thanks a lot for your pull request! I see your point, but your suggestion as is doesn't work either, given that I mention only two colors afterwards ("in orange and yellow"). What I meant with "disjoint" is disjoint from the subgroup (in red) and disjoint from one another. (This becomes clearer in the next caption, where I write about "the only disjoint coset".) How do you feel about simply adding an additional sentence, such as the following: "Since the subgroup is also a coset, there are three disjoint cosets overall."? (Here's a link to this section for later reference.)

skaunov commented 1 year ago

Oh, you're totally right! Actually I didn't payed enough attention to the end of the sentence with color names. =( I'm slightly color blind, so didn't saw the difference on the picture itself (saw only green and "other", lol), so proposed what seemed to me as a compact improvement.

PS Sorry for delay, couldn't get back earlier.