Kasper24 / KwesomeDE

A desktop environment made in AwesomeWM
329 stars 18 forks source link

Externals Broken: point to non public commits #12

Closed Ryex closed 1 year ago

Ryex commented 1 year ago

At this time there are at least two

external/filesystem external/xml2lua

$ git submodule update --init
Submodule 'filesystem' (https://github.com/sclu1034/lgi-async-extra) registered for path 'external/filesystem'
Submodule 'xml2lua' (https://github.com/manoelcampos/xml2lua) registered for path 'external/xml2lua'
fatal: transport 'file' not allowed
fatal: Fetched in submodule path 'external/filesystem', but it did not contain 00adcd124c204253d47865f0ccc4deefe44958a4. Direct fetching of that commit failed.

In the past Bling has behaved this way as well

currently this is causing this error

error while running function!
stack traceback:
    ./daemons/system/theme.lua:759: in upvalue 'scan_wallpapers'
    ./daemons/system/theme.lua:1324: in local 'new'
    ./daemons/system/theme.lua:1352: in main chunk
    [C]: in function 'require'
    ./rc.lua:17: in main chunk
    [C]: in function 'require'
    /home/ryex/Packages/KwesomeDE/rc-debug.lua:9: in main chunk
error: ./daemons/system/theme.lua:759: attempt to call a nil value (field 'make_directory_with_parents')

If you are going to continue manually modifying the externals I would suggest pointing the submodules at your own public forks instead of the origin/upstream repo.

Kasper24 commented 1 year ago

Sorry, I forgot to push the modifications I made. Does it work now?

Ryex commented 1 year ago

well, it was working. but you have unpunished commits again. :P

there has got to be a git hook or something to prevent that kind of thing...

Kasper24 commented 1 year ago

Sorry, fixed it again and made it point to my repos instead now.