search

KaspianDev / AntiPopup

Plugin giving back privacy that server owners deserve.
GNU General Public License v3.0
144 stars 19 forks source link

Intermittent EncoderException #37

Closed SlimeDog closed 1 year ago

SlimeDog commented 1 year ago

Describe the bug

Intermittent EncoderException. It occurs intermittently on server restart. It also occurs intermittently after server restart.

To Reproduce

Expected behavior

(Relatively) clean start-up

Operating System

CentOS Linux release 7.9.2009 (Core)

Server Software

Spigot 1.19.3-3647 or Paper 1.19.3-386

Server Version

1.19.3

Proxy Type

None

Plugin List

Lots. See attached log file.

Server logs

REMOVED REMOVED

KaspianDev commented 1 year ago

Does it show up when my plugin isn't present?

SlimeDog commented 1 year ago

Does it show up when my plugin isn't present?

No. I should have made that clear.

KaspianDev commented 1 year ago

Please open an issue on PacketEvents

SlimeDog commented 1 year ago

Done.

SlimeDog commented 1 year ago

There have been quite a few commits to https://github.com/retrooper/packetevents/commits/2.0 (the branch I believe AntiPopup is using) since the version used in AntiPopup 5.3. In fact, the number of commits posted daily is truly startling. No idea if any of them address this particular issue. The linked issue has received no response, to date.

For now, I have reverted to AntiPopup 5.2, which uses a previous version of PacketEvents and does not exhibit this error.

KaspianDev commented 1 year ago

Check this for latest packetevents

SlimeDog commented 1 year ago

Did you test it? I got the same issue, on the first try. Retrooper still has not responded to the linked issue.

SlimeDog commented 1 year ago

More important, I don't see any test modules in the PacketEvents source (perhaps I missed them, but I don't think so). It seems unwise to rely on completely untested code in your own plugin, especially given the code-du-jour updates that aren't tested. Perhaps you should consider extracting the relevant code (how many protocol interfaces does AntiPopup use?) since it's published under a GPL3 license, so that you can test your own usage without reliance on untested bleeding edge interfaces, or risk them changing out from under you.

KaspianDev commented 1 year ago

Did you test it? I got the same issue, on the first try. Retrooper still has not responded to the linked issue.

yeah sorry i couldnt test that one and it causes issues for me too, im waiting for their response

RainbowTea commented 1 year ago

I'm having the same issue i think? https://hastebin.com/share/fukumodeta.markdown

Adding to it and not opening a new issue. Hope that's okay..

KaspianDev commented 1 year ago

I'm having the same issue i think? https://hastebin.com/share/fukumodeta.markdown

Adding to it and not opening a new issue. Hope that's okay..

message me on discord/matrix

SlimeDog commented 1 year ago

Per https://github.com/retrooper/packetevents/issues/533#issuecomment-1428423653, this issue has been resolved.

KaspianDev commented 1 year ago

ive made a test release here. note it is untested since i cant reproduce the issue.

lmk if it works and ill push to spigot

SlimeDog commented 1 year ago

5.4-RC2 running on Paper and Spigot for nearly two hours, including a few restarts, without error.

KaspianDev commented 1 year ago

okay lets give it time till im back from school tomorrow @RainbowTea maybe you also wanna test?

arturek1666 commented 1 year ago

Oh I have that issue as well will get the test release as well and see how it goes :)

KaspianDev commented 1 year ago

sweet

RainbowTea commented 1 year ago

okay lets give it time till im back from school tomorrow @RainbowTea maybe you also wanna test?

Booted up with no errors so far! Thank you :)