KaspianDev / AntiPopup

Plugin giving back privacy that server owners deserve.
GNU General Public License v3.0
147 stars 19 forks source link

Suggestion, make the plugin MUG compliant #97

Closed smashyalts closed 3 months ago

smashyalts commented 3 months ago

The popup needs to be shown to be MUG compliant, hiding it is against the MUG (Minecraft usage guidelines) and therefor can get a server blacklisted, I suggest either removing the popup hiding completely or making it shown by default with a config option for people who don't care about following the game's rules. image the MUG rule being broken https://www.minecraft.net/en-us/usage-guidelines#commercial image image Gamersafer image IP Justice (Mojang Enforcement Agent) (keeping the chat signing disabled Is fine (for now))

KaspianDev commented 3 months ago

I don't see how a plugin that uses vanilla server features (no weird hacks are done, I'm only modifying existing packet property which is a part of the game) would be violating some weird rules.

Also remember, AntiPopup itself isn't masking any behavior, client still sees that a chat message isn't signed by hovering on the left side of chat bar. Once you hover you will see a message explaining that the message is a "Server Message".

Blocking the popup is literally the same as toggling enforce-secure-profile but without any potential bad side-effects.

If mojang wants to enforce the rules they would have to ban all <1.19.1 servers because they might be hiding the popup during packet translation.

KaspianDev commented 3 months ago

tl;dr don't care

If you have anything to add please do.

smashyalts commented 3 months ago

every message being seen as a server message and the popup are two different things, the popup (chat signing is disabled and therefor the warning needs to be there), if you could read the "proof" I included, chat signing (player messages sent as server messages) is "fine" (for now) but hiding or causing the popup to be hidden when it should be visible is against the MUG

KaspianDev commented 3 months ago

I am not changing that behavior, that's the core part of AntiPopup, hence the name.

If you hate your players and you wanna torture them with the popup on each join you can reenable popup in the config while keeping chat reporting disabled.

smashyalts commented 3 months ago

i dont hate my players but people dont know its against the MUG and keeping a plugin MUG non-compliant is not good, even if its the name or not

KaspianDev commented 3 months ago

I don't care about unrealistic rules to be honest.

Again, if mojang really wanted the popup they wouldn't give servers the authority to control it. It's literally a feature in the game's protocol, designed that way on purpose.

0n commented 3 months ago

🤓

JerichoTorrent commented 3 months ago

I don't see how a plugin that uses vanilla server features (no weird hacks are done, I'm only modifying existing packet property which is a part of the game) would be violating some weird rules.

This is the same logic used to justify running a cracked server just because offline-mode is a setting in server.properties. It's still against the rules; point blank. Mojang Enforcement themselves has stated that your plugin violates the MUG. The right thing to do is AT LEAST put a note in your readme.md disclosing the fact that this plugin could get you in hot water and lead to your server getting blacklisted from authentication servers.

Your response clearly shows you care nothing for the people who use your plugin nor the community at large.

0n commented 3 months ago

I don't see how a plugin that uses vanilla server features (no weird hacks are done, I'm only modifying existing packet property which is a part of the game) would be violating some weird rules.

This is the same logic used to justify running a cracked server just because offline-mode is a setting in server.properties. It's still against the rules; point blank. Mojang Enforcement themselves has stated that your plugin violates the MUG. The right thing to do is AT LEAST put a note in your readme.md disclosing the fact that this plugin could get you in hot water and lead to your server getting blacklisted from authentication servers.

Your response clearly shows you care nothing for the people who use your plugin nor the community at large.

🤓

KaspianDev commented 3 months ago

I don't see how a plugin that uses vanilla server features (no weird hacks are done, I'm only modifying existing packet property which is a part of the game) would be violating some weird rules.

This is the same logic used to justify running a cracked server just because offline-mode is a setting in server.properties. It's still against the rules; point blank. Mojang Enforcement themselves has stated that your plugin violates the MUG. The right thing to do is AT LEAST put a note in your readme.md disclosing the fact that this plugin could get you in hot water and lead to your server getting blacklisted from authentication servers.

Your response clearly shows you care nothing for the people who use your plugin nor the community at large.

  1. Which part of the mug does offline mode break? You realize half of the servers (according to bstats) are offline mode and somehow they aren't banned? I've been playing the game since super early versions and some offline servers from back then exist today, 10+ years later.
  2. If you were following the conversation you'd know that antipopup has an option to reenable the popup.
  3. I don't listen to nor trust people who are behind intrusive authentication systems.
smashyalts commented 3 months ago

Offline-mode isnt against the MUG, letting people without a legitimate account is (which is what offline-mode allows), the popup should be disabled by default and just let the config option be there to enable it again for people who don't care, and yes offline-mode servers arent actively being enforced on at this moment but will in the future, as confirmed by ip_justice, and also he was comparing "logic", just because its in the protocol (how else would the server sent to the client that info?), and you can manipulate it doesn't mean its following the MUG or allowed

KaspianDev commented 3 months ago

I'm not changing defaults. If you wish to enable the popup you are free to do so.

KaspianDev commented 3 months ago

If you'd like to continue the discussion feel free to do so on my discord server.