search

KastanDay / ai-ta-frontend

Chat with your documents. Upload anything, get answers.
https://www.uiuc.chat/
15 stars 7 forks source link

fixed qdrant doc groups functionality for files without url field #150

Closed Maxwell-Lindsey closed 5 months ago

Maxwell-Lindsey commented 5 months ago

url field is null by default in qdrant - adjusted logic accordingly

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uiuc-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:20pm
sweep-ai[bot] commented 5 months ago

Sweep: PR Review

Sweep has finished reviewing your pull request.

Reviewed Files

src/utils/qdrantUtils.ts

Summary of changes made:

The pull request introduces a commented-out function for retrieving the collection schema, modifies the search filter to conditionally include the `url` key, and adds logging statements for debugging purposes.

Potential Issues

  • The added `console.log` statements may expose sensitive information in the logs, which could be a security concern.
    • https://github.com/KastanDay/ai-ta-frontend/blob/56ae6aa879de8a5deb27b792802e69ecf9373d4d/src%2Futils%2FqdrantUtils.ts#L50-L53
  • The conditional inclusion of the `url` key in the search filter may lead to unexpected behavior if `doc.url` is undefined, potentially causing issues in downstream processing.
    • https://github.com/KastanDay/ai-ta-frontend/blob/56ae6aa879de8a5deb27b792802e69ecf9373d4d/src%2Futils%2FqdrantUtils.ts#L36-L41