search

KastnerRG / riffa

The RIFFA development repository
https://riffa.ucsd.edu
Other
766 stars 313 forks source link

Python x64 and python3 fixes #2

Closed jrobrien closed 8 years ago

jrobrien commented 8 years ago

Added type signatures to properly pass (64 bit) pointers for *data. Send/recv was failing in driver when a truncated address was passed. This probably could affect any 64 bit system depending on where memory was allocated, though only saw it on x64 Ubuntu 14.04.

Not sure about passing *fpga, but set it to a pointer anyway.

Changed to truncating division to support python 3. Normal Division in python 3 returns a float which could cause problems.

drichmond commented 8 years ago

Looks good, going to take a while to integrate/test (short on time), but I like the fix.

Thanks!

drichmond commented 8 years ago

Can you retarget your pull request to RIFFA 2.2.2?

Thanks!