search

Kaszanas / SC2InfoExtractorGo

GNU General Public License v3.0
0 stars 2 forks source link

gameTime from metadata equal to 0 in old replays #32

Closed Kaszanas closed 3 years ago

Kaszanas commented 3 years ago

This issue is for replays from 2016 where the metadata returns gameTime of 0.

For the sake of keeping the data structure in the most original form it is clear that for summary information creation and integrity checks there needs to be verification if game time is indeed equal to 0 in all of the fields that contain game time.

Kaszanas commented 3 years ago

If gameTime is equal to 0 in metadata logic was introduced to get this information from elsewhere. Further data ingestion code also needs to take this under consideration.