search

Kaszanas / SC2_Datasets

https://sc2-datasets.readthedocs.io/
GNU General Public License v3.0
8 stars 3 forks source link

[PR] 1.0.0 Kaszanas #14

Closed Kaszanas closed 2 years ago

Kaszanas commented 2 years ago

The Dataset, and DataModule classes seem to be fully implemented. These abstractions clearly work.

As of now there are few issues with some potentially corrupted files or files that may contain unsupported characters.

Issues that were solved and can be code reviewed: https://github.com/Kaszanas/SC2EGSet_Experiments/issues/5 https://github.com/Kaszanas/SC2EGSet_Experiments/issues/10

The following issues need to be examined and solved later: https://github.com/Kaszanas/SC2EGSet_Experiments/issues/13

fyi: @leafnode can you briefly code review?