search

Kaszanas / SC2_Datasets

https://sc2-datasets.readthedocs.io/
GNU General Public License v3.0
8 stars 3 forks source link

Replaypack dataset tests #2

Closed Kaszanas closed 2 years ago

Kaszanas commented 2 years ago

So far there are some drafted tests in replaypack_dataset_test.py.

length of the replaypack is calculated on SC2ReplaypackDataset initialization and is the len of the os.listdir.

Therefore it is not clear if at any given point in time the __getitem__ will not break because of the underlying json parsing logic.

@leafnode if You have any thoughts on that please let me know.

Kaszanas commented 2 years ago

This is outdated.