search

Kaszanas / SC2_Datasets

https://sc2-datasets.readthedocs.io/
GNU General Public License v3.0
8 stars 3 forks source link

PlayerId is zero #38

Open rhys-newbury opened 7 months ago

rhys-newbury commented 7 months ago

I went to look at the JSON files, and some of the playerId's are 0 for both players, but in the code, they are assumed to be '1' or '2'. Is there a mistake in the data I downloaded?

image

Kaszanas commented 7 months ago

I went to look at the JSON files, and some of the playerId's are 0 for both players, but in the code, they are assumed to be '1' or '2'. Is there a mistake in the data I downloaded?

image

This issue is most likely due to the frequent changes to StarCraft 2 Legacy of the Void upon it's release. I will try to verify this specific JSON against other files.

But when checked at random, files from more recent tournaments do not suffer from this issue. I will also report this issue in the data parsing repository: https://github.com/Kaszanas/SC2InfoExtractorGo