search

Kaszanas / SC2_Datasets

https://sc2-datasets.readthedocs.io/
GNU General Public License v3.0
8 stars 3 forks source link

Potentially Renaming Dataset Classes #41

Open Kaszanas opened 7 months ago

Kaszanas commented 7 months ago

currently the SC2EGSetDataset class takes an additional argument that specifies the available_replaypacks. This behavior is more alike to a generic class that could more than just this given dataset. Therefore, it may be renamed and the SC2EGSetDataset class could be left with a deprecation notice and ultimately be discarded at some point.

Kaszanas commented 7 months ago

Similar issue is there for providing names_urls keyword argument to this class, by default this class should be self-evident and always contain the data from the Zenodo repository. This interface should be verified.