KatIsCoding / JSCapstone

4 stars 1 forks source link

Github Project Setup Review #21

Closed KatIsCoding closed 3 years ago

KatIsCoding commented 3 years ago

Project link: https://github.com/KatIsCoding/JSCapstone/projects/1 Note: We are only 2 members

henatan99 commented 3 years ago

Hi team,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

## Required Changes ♻️ - [x] There should be a circle with the user's avatar on each card, so as to make sure tasks are assigned fairly for each member of the team. See the example below: ![image](https://user-images.githubusercontent.com/64894927/136834338-a205c8ae-dfd8-42c6-96aa-2a13a52ab074.png) ## Optional suggestions _Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better._ Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. **_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._** ------ _As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._
henatan99 commented 3 years ago

Hi team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

mike2611 commented 3 years ago

Thanks for the review