search

KatIsCoding / Portfolio

Personal Portfolio inspired in a template provided by @Microverse
4 stars 0 forks source link

Modal changes added #11

Closed KatIsCoding closed 3 years ago

KatIsCoding commented 3 years ago

In this update the modals for both desktop and mobile version have been added. The modals are responsive and with a great design (from template). They are also using functioning javascript

KatIsCoding commented 3 years ago

Hi @Davidosky007, The modal close button is invisible because it is white and that's how it should be according to the template, since I only have one code review left I would like to know what should I do? Because the version I have is correct according to the template.

KatIsCoding commented 3 years ago

@Davidosky007 Please let me know how to proceed, in which case you don't show up I'll be requesting a second opinion, have a great day/night.

Davidosky007 commented 3 years ago

@Davidosky007 Please let me know how to proceed, in which case you don't show up I'll be requesting a second opinion, have a great day/night.

Hi, you can make the colour of the close icon visible (ie black since its a white background) and also make the content of the modal fit like the design template yours is moving out of the white background just try to make it look as close as possible to the template 👍