KatalysatorAB / atom-ember-tabs

Makes atom.io work better with Ember pods.
MIT License
26 stars 5 forks source link

Uncaught TypeError: item.getPath is not a function #11

Closed jamemackson closed 7 years ago

jamemackson commented 8 years ago

When I open a file that's not in an ember application I get this error.

Atom Version: 1.7.3 System: Mac OS X 10.11.4 Thrown From: ember-tabs package, v2.2.2

Stack Trace

Uncaught TypeError: item.getPath is not a function

At /Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:58

TypeError: item.getPath is not a function
    at TabWatcher.module.exports.TabWatcher.getEmberPodName (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:58:5)
    at TabWatcher.getEmberPodName (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:1:1)
    at TabWatcher.module.exports.TabWatcher.updateTabTitle (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:44:70)
    at TabWatcher.updateTabTitle (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:1:1)
    at TabWatcher.<anonymous> (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:39:10)
    at TabWatcher.module.exports.TabWatcher.updateTabTitles (/Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:38:7)
    at /Users/jmackson/.atom/packages/ember-tabs/lib/tab-watcher.coffee:1:1

Commands

     -2:42.3.0 editor:newline (atom-text-editor.editor.is-focused)
     -2:38.9.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused.autocomplete-active)
     -1:51 symbols-view:go-to-declaration (atom-text-editor.editor.is-focused)
     -1:32.9.0 settings-view:open (atom-text-editor.editor.is-focused)
     -1:26.3.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -1:25.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:12.2.0 emmet:merge-lines (atom-text-editor.editor.is-focused)
     -0:10.2.0 bracket-matcher:select-inside-brackets (atom-text-editor.editor.is-focused)
     -0:07.2.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:07.2.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:07.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:07.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:05.9.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:05.9.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:05.6.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:05.6.0 core:cancel (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "destroyEmptyPanes": false
  }
}

Installed Packages

# User
atom-beautify, v0.29.7
atom-ember-author-kit, v0.6.6
atom-handlebars, v1.3.0
atom-remove-keybindings-collisions, v0.1.0
autocomplete-bash-builtins, v0.3.4
autocomplete-js-import, v1.0.1
build-ember, v0.0.1
ember-addon-snippets, v1.0.0
ember-cli-helper, v0.9.0
ember-snippets, v1.4.0
ember-tabs, v2.2.2
emmet, v2.4.3
file-type-icons, v1.2.0
file-watcher, v0.4.0
git-commit, v1.5.2
git-plus, v5.13.4
git-status, v0.3.4
highlight-selected, v0.11.2
language-ansible, v0.1.3
language-dotfiles, v0.2.0
language-ember-htmlbars, v0.3.0
linter, v1.11.4
linter-ansible-linting, v1.1.2
linter-ansible-syntax, v1.0.0
linter-checkbashisms, v0.1.5
linter-shellcheck, v1.2.0
logo-file-icons, v1.1.5
minimap, v4.23.5
minimap-codeglance, v0.4.5
minimap-cursorline, v0.1.0
minimap-find-and-replace, v4.5.1
minimap-hide, v0.3.0
minimap-highlight-selected, v4.4.0
minimap-linter, v1.1.1
split-diff, v0.7.5
ssh-config, v0.10.1
term3, v0.22.0

# Dev
No dev packages
xdumaine commented 7 years ago

This just started happening to me on Atom 1.17

davelowensohn commented 7 years ago

Same here. 1.17.0 x64, OSX 10.11.6

erkie commented 7 years ago

Can you update to 2.4.3 and see if it fixes it?

davelowensohn commented 7 years ago

We're running a fork, but I merged in your patch & the error went away. Thanks for the quick fix!

erkie commented 7 years ago

Cool fork! 💃