search

KatalysatorAB / atom-ember-tabs

Makes atom.io work better with Ember pods.
MIT License
26 stars 5 forks source link

Does not work in pods subdirectory #3

Closed medokin closed 8 years ago

medokin commented 9 years ago

Any plan to address this issue?

image

erkie commented 9 years ago

@medokin Oops. What exactly does your podModulePrefix contain?

medokin commented 8 years ago

podModulePrefix: 'webapp/pods',

DanChadwick commented 8 years ago

Same issue. Would love to see a fix. :)

erkie commented 8 years ago

@medokin @DanChadwick can you try the 2.1.0 update and see if it fixes your issues? If it does, you can close this issue!

DanChadwick commented 8 years ago

I tried 2.1.0 but I don't see a difference. I haven't gotten the podModulePrefix to work in ember (or atom, for that matter). Without any podModulePrefix (or with), I don't get the folder name in the tab name. ctrl-shift-m doesn't do anything (on Windows). I don't see any command in the advanced palette containing 'pod'.

I'm pretty new to ember and atom. I wish I could be of more help.

DanChadwick commented 8 years ago

I'm confused. What I'm seeing is that atom, without atom-ember-tabs, distinguishes tabs when two have the same name, in the form "index.js - app\controllers". I don't see any change in behavior with the add-on enabled.

erkie commented 8 years ago

@DanChadwick can you try installing 2.1.2 and see if it works? Close the issue if it does. Thanks!

DanChadwick commented 8 years ago

I just updated and don't see the parent folder in the tab -- only the complete path when I hover. But them, I'm not sure that I have pods working at all. I tried both with and without a podModulePrefix.

robneville73 commented 8 years ago

+1 on 2.1.2 and not working as intended. I have no podModulePrefix defined as I don't use one. My pods structure works fine for the application so I know that part's right.

erkie commented 8 years ago

@robneville73 @DanChadwick I identified some places that could cause the project to not load properly. Can you update to 2.1.3 and check if it works?

DanChadwick commented 8 years ago

I tried 2.1.3. At this point, I have no podModulePrefix. I created component with ember g --pods and opened both the test-item/component.js and test-item/template.hbs files. The tab does not have test-item in it.

erkie commented 8 years ago

What does your .ember-cli file look like?

robneville73 commented 8 years ago

@erkie nope, doesn't work in 2.1.3 either.

Here's my .ember-cli file:

{
"disableAnalytics": false,
"usePods": true
}
erkie commented 8 years ago

@robneville73 Can you open the console and see what message you are getting there? cmd+shift+i (or View > Developer > Toggle Developer Tools) and press the Console tab. You should see some messages with [ember-tabs] prefixed. That would help a lot!

robneville73 commented 8 years ago

2/Users/rneville/.atom/packages/ember-tabs/lib/ember-tabs.coffee:71 [ember-tabs] Did not detect ember project with pods enabled. /Users/rneville/.atom/packages/ember-tabs/lib/ember-tabs.coffee:68 [ember-tabs] Detected Ember project. loft-mobile/pods. /Users/rneville/.atom/packages/ember-tabs/lib/tab-watcher.coffee:13 [ember-tabs] Shimming tabs...

On Fri, Nov 13, 2015 at 9:28 AM, Erkie notifications@github.com wrote:

@robneville73 https://github.com/robneville73 Can you open the console and see what message you are getting there? cmd+shift+i (or View > Developer > Toggle Developer Tools) and press the Console tab. You should see some messages with [ember-tabs] prefixed. That would help a lot!

— Reply to this email directly or view it on GitHub https://github.com/KatalysatorAB/atom-ember-tabs/issues/3#issuecomment-156447006 .

Rob Neville RetailArchitects

(888) 891-4511 x801

For Support: (888) 891-4511 Option 1 or support@retailarchitects.com

robneville73 commented 8 years ago

2.1.5 still borked. :(

erkie commented 8 years ago

@robneville73 can you send a screenshot of the console? View > Developer > Toggle Developer Tools

robneville73 commented 8 years ago

[ember-tabs] Everying read fine. Settings: true and loft-mobile/pods /Users/rneville/.atom/packages/ember-tabs/lib/ember-tabs.coffee:68 [ember-tabs] Detected Ember project. loft-mobile/pods. /Users/rneville/.atom/packages/ember-tabs/lib/tab-watcher.coffee:13 [ember-tabs] Shimming tabs... 3/Users/rneville/.atom/packages/ember-tabs/lib/tab-watcher.coffee:123 [ember-tabs] filePath: /Users/rneville/loft-mobile/app/pods/zipcode/edit/template.hbs was not an ember package path. Checked against: loft-mobile/pods

robneville73 commented 8 years ago

Looks like it's expecting pods to be at top level and not under the apps directory

erkie commented 8 years ago

@robneville73 Hmm not sure, it seems from the console messages you sent that it's not updated properly. Can you restart atom and send a screenshot of the console this time, after you try to cmd+shift+m?

robneville73 commented 8 years ago

@erkie we're good. Just hadn't restarted Atom yet. It appears to be working now. Thanks!!