search

Katellification / codecademy-project-3-scoop

This is project content for Codecademy course:
0 stars 0 forks source link

Summary #4

Open zannain opened 6 years ago

zannain commented 6 years ago

Great work on getting all the test to pass for this API project! I was, however, unable to start your project on a local server so I was unable to comment on the UI aspect of the project. Your application logic was solid and well planned out. Work on organizing it into digestible components because applications get bigger as features are added and having it all in one file is not best practice. Work on getting that UI to work because while its great that your test pass, ultimately that's not very assuring to a user visiting your web page. Keep it up!

Needs improvement

Katellification commented 6 years ago

That's really odd. It was running fine on my end, would save the data you entered on the website in the file and load up when you killed the server and reset it. A bug would come up outside of the test suite that I couldn't locate with my current javascript knowledge, but it definitely runs on my local machine once I load the server...

This leads me to a question for future codecademy submissions (this was my first): what do we need to upload on git? because the folder with all the libraries got massive and I'm not sure you need the whole thing. It seems you only cared about the code I modified and not the whole project? But then if I used a particular library that wasn't instructed to be loaded with the project description (which I did and am assuming is causing the issue, though I could be wrong), where does that go? In a readme file or similar node.js set of commands/script? That wasn't made clear in the instructions of the project.

Thank you for your set of comments though, they were helpful.

zannain commented 6 years ago

When you create a git repository locally, git should create a file called .gitignore. If it doesn't you can create it yourself, just make sure you are appending the . to it. Files and directories you list in here will be excluded when you push to your repository on Github.

You can list node_modules in the .gitignore file and even delete the entire directory off your machine locally. Your package.json has a list of all the packages and dependencies needed to run your app. So if you delete your node_modules directory or you clone a node application, the only thing you have to do then is run npm install and this command will look in the package.json file an install the dependencies listed in there and put them into a folder called node_modules.