search

Katello / katello-packaging

[DEPRECATED] Packaging for Katello
7 stars 33 forks source link

Remove python-urllib3 in favor of whats in base #471

Closed ehelms closed 7 years ago

ehelms commented 7 years ago

The version in base CentOS has caught up so we don't need to carry this anymore.

theforeman-bot commented 7 years ago

There were the following issues with the commit message:

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

evgeni commented 7 years ago

I don't see https://github.com/Katello/katello-packaging/blob/master/python-urllib3/key-connection-pools-off-custom-keys.patch being part of https://git.centos.org/blob/rpms!python-urllib3/c7/SPECS!python-urllib3.spec?

ehelms commented 7 years ago

I don't have a clue what that spec file you linked is from, but EPEL has python-urllib3 1.19.1 which was released in November 2016 (https://dl.fedoraproject.org/pub/epel/7/x86_64/p/python34-urllib3-1.19.1-3.el7.noarch.rpm)

evgeni commented 7 years ago

That spec is fron CentOS (not EPEL) git.

ehelms commented 7 years ago

Ok, but what's in EPEL is what we care about since that's what a user will install?

On Jul 6, 2017 7:30 PM, "Evgeni Golov" notifications@github.com wrote:

That spec is fron CentOS (not EPEL) git.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Katello/katello-packaging/pull/471#issuecomment-313546899, or mute the thread https://github.com/notifications/unsubscribe-auth/AAR585dH2AYIJrVAhbZTUBP-alMo7Lt3ks5sLW4egaJpZM4N-cXe .

evgeni commented 7 years ago

But EPEL has only python34-urllib3, not python-urllib3 (EPEL can't ship newer versions of packages in CentOS/RHEL proper).