Fixes #20431 - ignore services in the static state

Katello / katello-packaging

[DEPRECATED] Packaging for Katello

7 stars 33 forks source link

Closed ehelms closed 7 years ago

theforeman-bot commented 7 years ago

Issues: #20431

ehelms commented 7 years ago

@beav Please to take a look at this.

beav commented 7 years ago

looks good to me. This removes el6 support which is fine by me, but you may want to mention it in the commit message.

beav commented 7 years ago

ACK aside from adding upstart removal note in commit message

evgeni commented 7 years ago

ACK on the change, but I also think we should fix katello-remove to either be a proper katello-uninstaller or stop pretending being one ;)

ehelms commented 7 years ago

@evgeni want to file a separate issue to tackle your comment?

theforeman-bot commented 7 years ago

There were the following issues with the commit message:

length of the first commit message line for 9305175e5381ab781177fbd357b132251528b5a5 exceeds 65 characters

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.

This message was auto-generated by Foreman's prprocessor

ehelms commented 7 years ago

Updated the commit message, merging now

evgeni commented 7 years ago