search

Katello / katello-packaging

[DEPRECATED] Packaging for Katello
7 stars 33 forks source link

fixes #21198 - unmounts/removes snapshots if failure #549

Closed cfouant closed 6 years ago

theforeman-bot commented 6 years ago

Issues: #21198

cfouant commented 6 years ago

@evgeni - could you review this please? You're the best versed at snapshots :100:

cfouant commented 6 years ago

@evgeni - thanks for the suggestions, thanks for testing! @johnpmitsch - i changed the command in helper.rb because system() automatically returns true/false and is less expensive than backtick calls. (just learned this, and thinking we might want to test using system() throughout, although doubt it would work everywhere). Let me know what you think! I can take it out if you prefer.

cfouant commented 6 years ago

ping @evgeni @johnpmitsch - could i haz re-review when you get the opportunity? Thanks!

johnpmitsch commented 6 years ago

LGTM :+1: (I'll let evgeni approve to merge)

jlsherrill commented 6 years ago

merged! thanks @cfouant !