Closed cfouant closed 6 years ago
@evgeni - could you review this please? You're the best versed at snapshots :100:
@evgeni - thanks for the suggestions, thanks for testing! @johnpmitsch - i changed the command in helper.rb because system() automatically returns true/false and is less expensive than backtick calls. (just learned this, and thinking we might want to test using system() throughout, although doubt it would work everywhere). Let me know what you think! I can take it out if you prefer.
ping @evgeni @johnpmitsch - could i haz re-review when you get the opportunity? Thanks!
LGTM :+1: (I'll let evgeni approve to merge)
merged! thanks @cfouant !
Issues: #21198