search

Katello / katello-packaging

[DEPRECATED] Packaging for Katello
7 stars 33 forks source link

3.5.2 Cherry Picks from foreman-packaging #582

Closed akofink closed 6 years ago

akofink commented 6 years ago

@jturel @johnpmitsch Care to review your commits? This didn't really cherry pick cleanly, probably because it's from a completely different repo.

theforeman-bot commented 6 years ago

Issues: #21795

johnpmitsch commented 6 years ago

@akofink https://github.com/Katello/katello-packaging/pull/582/commits/3bf96ae9490eb3f6eff3af0737884bbf7ee9cc40 looks fine to me

johnpmitsch commented 6 years ago

Once we get the cherry-picks straightened out, it would be a good idea to run these commands manually. As far as I know, we don't do this in the release pipeline (another good part about moving these to foreman-maintain!)

akofink commented 6 years ago

Kicked http://projects.theforeman.org/issues/21517 from 3.5.2, so now it's just the one issue.

johnpmitsch commented 6 years ago

@akofink looks like its missing the first change here?

akofink commented 6 years ago

Rogue cherry-pick! Good catch. Updated. :)