Closed Katended closed 1 year ago
Hi @Katended 👋👋,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that doesn't have contributions from your learning partner🥲 don't forget, this is a pair programming activity and the contribution of your partner is also required😉 this was omitted by the first reviewer but it is a requirement😉 Kindly reach out to your learning partner and work with him👍
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
@Ibizugbe While I understand the message of an Invalid Review Request. I find my changes on this PR as one of the last commit that fixes the change request made by the previous review. Please point me exactly where the issue is. Thank you.
Hello @Katended I think I stated the issue in the comment let me quote it here again ☺️
You have submitted a project, that doesn't have contributions from your learning partner🥲 don't forget, this is a pair programming activity and the contribution of your partner is also required😉 this was omitted by the first reviewer but it is a requirement😉 Kindly reach out to your learning partner and work with him👍
We require you to work with your pair programming partner for this milestone. From your commit message, it's seems you haven't done that. The previous reviewer should have pointed that but probably didn't take note of it.. but this is a compulsory requirement.👍
Hope you're clear now?🤔
Hello @Katended I think I stated the issue in the comment let me quote it here again ☺️
You have submitted a project, that doesn't have contributions from your learning partner🥲 don't forget, this is a pair programming activity and the contribution of your partner is also required😉 this was omitted by the first reviewer but it is a requirement😉 Kindly reach out to your learning partner and work with him👍
We require you to work with your pair programming partner for this milestone. From your commit message, it's seems you haven't done that. The previous reviewer should have pointed that but probably didn't take note of it.. but this is a compulsory requirement.👍
Hope you're clear now?🤔
@Ibizugbe Ok sure thanks.
Also @Katended , I noticed I made use of the approve
feature to drop the comment, probably this may have caused a bit of confusion. but I sincerely apologise as that was a mistake on my part🥲 I should have dropped a normal comment or use the comment
feature. But I am you understand now👍
Thanks for understanding and Happy coding👍
The following have been added: