tugsem
commented
1 year ago STATUS: REQUIRED CHANGES ♻️
Hello @Katended and @samiullah12345678 👋 ,
Good job so far! 👏 There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🚀
✔️linters are passing ✔️ Correct use of GitHub flow ✔️professional documentation
Required Changes ♻️
- Nice report overall, however when I check the color-contrast ratio, I see 4 failing elements. You can check them too using this site: https://www.aditus.io/button-contrast-checker/. Kindly fix this.
- Contrast ratio should be at least 4.5:1.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Sami-Ullah-Tufail
The following have been addressed in the pull request:
Page titles:
Updated the title of the page to be more descriptive
https://github.com/Katended/mobilefirstproject2/pull/8/files#diff-ba9f3fbde9c0c98a09b8fcb805a096ed053753a7b7d2844dca83ad9907e720ccR7
Image text alternatives: Added image alt-text to project images:
https://github.com/Katended/mobilefirstproject2/pull/8/files#diff-ba9f3fbde9c0c98a09b8fcb805a096ed053753a7b7d2844dca83ad9907e720ccR7
https://github.com/Katended/mobilefirstproject2/pull/8/files#diff-ba9f3fbde9c0c98a09b8fcb805a096ed053753a7b7d2844dca83ad9907e720ccR99
https://github.com/Katended/mobilefirstproject2/pull/8/files#diff-ba9f3fbde9c0c98a09b8fcb805a096ed053753a7b7d2844dca83ad9907e720ccR99
Text headings No Issues
Color contrast No Issues
Resize Removed size property in first section to prevent link overlaps on when page is zoomed.
https://github.com/Katended/mobilefirstproject2/pull/8/commits/3bee93fcffa2e4887c2422ddea99916bb83243ff#diff-b78be019f1dc6d57753ea900c3805b114cd53ab7c0db836cc081836df1b99b7aR113
Interaction
Added form labels to improve accessibility.
Moving content Added alt text to moving logo image https://github.com/Katended/mobilefirstproject2/pull/8/commits/f1bdac595432038f87fd51c400867259e177c547#diff-ba9f3fbde9c0c98a09b8fcb805a096ed053753a7b7d2844dca83ad9907e720ccR16
Multimedia No Issues
The basic structure of the page
No Issues