search

KateriSalk / Alaska_IR_Automation

0 stars 1 forks source link

Chloride drinking water use not analyzed #26

Open petjen25 opened 2 months ago

petjen25 commented 2 months ago

https://github.com/KateriSalk/Alaska_IR_Automation/blob/55232c13b2591cb37aa75c06c7b52826d825f809/Code/6_Analysis/magdurfreq_functions.R#L232 https://github.com/KateriSalk/Alaska_IR_Automation/blob/55232c13b2591cb37aa75c06c7b52826d825f809/Code/6_Analysis/magdurfreq_functions.R#L251

I noticed that chloride is getting analyzed for the aquatic life uses in the wqs crosswalk, but not the drinking water uses in the wqs crosswalk. I copied links to the parts of the MDF analysis that should be handling these uses. It isn't making sense to me why the samples aren't joining to the wqs for analysis.

ferribyh commented 1 month ago

So I think what's going wrong here is that Drinking Water Chloride is not making it out of the data_processing code. My current hypothesis is that it's getting removed when we match the sample fractions to the sufficiency crosswalk table fractions. Currently, DW chloride has a fraction of NA in our version of the data sufficiency crosswalk. If we change the NA to 'Dissolved' to match the Aquatic Life use it should solve this issue.

ferribyh commented 1 month ago

Just tested this by changed the Fraction text from NA to Dissolved and now Chloride for DW use is in the MDF output