Closed GioBar00 closed 2 months ago
- Why It allows to use images that someone might not want to give public access to. It is necessary to add this feature directly to Kathará since there is no straight forward way to do it separately. Kubernetes secrets are namespaced so one would need to create the Kubernetes secret after the namespace is created, but before the pods are deployed. This is not possible when deploying a lab in Kathará since the machines are created right after the namespace is.
I modified the code with the suggestions above.
Hi @GioBar00, thank you very much!
I will check the changes tomorrow and if everything is ok I will merge the PR in the develop
branch for the next release.
Hey @GioBar00, do you plan to add some tests for the new feature?
Otherwise, we could merge the PR and write them by ourselves to speed up the feature addition! 😄
Thanks, Mariano.
Sorry, currently I do not have time to look into it myself. Proceed with the merge. Sorry again and thanks 👍
- What I did
private_registry_dockerconfigjson
for a base64-encoded docker configuration.private-registry
of typekubernetes.io/dockerconfigjson
.image_pull_secret
argument to the pod specification referring to theprivate-registry
secret.- How I did it
KubernetesSettingsAddon.py
to add the new settingprivate_registry_dockerconfigjson
.KubernetesOptionHandler.py
to add the cli menu to enter or delete the setting.KubernetesNamespace.py
to create theprivate-registry
secret if the setting is set right after creating the namespace.KubernetesMachine.py
to add theimage_pull_secret
argument to the pod specification referring to theprivate-registry
secret if the setting is set.- How to verify it Create a private registry and get the docker config. Example of the file structure:
Compute the base64 encoding of the docker config and add it to Kathara settings. Deploy a lab with
kathara lstart
or a machine withkathara vstart
with an image available on the private registry.- Description for the changelog
Added support for private registries on Megalos
Resolves #283.