KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow
MIT License
11 stars 14 forks source link

Kimai v2 support #17

Closed designermonkey closed 6 months ago

designermonkey commented 1 year ago

Hello there! Are there any plan to support Kimai v2?

KatjaGlassConsulting commented 1 year ago

Hi, I have it on the radar, but think it might only come in Q4. Due to other priorities, I expect we switch to v2 somewhen next year.

pxlwrk commented 11 months ago

Would love to use it with Kimai2!

KatjaGlassConsulting commented 9 months ago

Dear all, we have decided not to switch to Kimai 2, and for this I do not plan any updates in the near future.

I created a new branch, so if someone has resources to update to Kimai version 2, I am happy to accept pull requests. You can also feel free to clone this repository and do updates elsewhere. I can include a link then.

pboissonneault commented 8 months ago

What are the main difference between Kimai2 v1.x and v2 that prevent this plugin to be updated ? I might have time later this year to look at this.

KatjaGlassConsulting commented 8 months ago

Hi, the updates requires according the block quite some changes: https://www.kimai.org/documentation/migration-v2.html

As my core customer has decided not to change to kimaiV2, I did not plan for the update myself, but would be happy if you could support.

One of the changes is the license with changed from MIT to GPLv3 which makes it different when code for a plugin is copied from the core tool.

pboissonneault commented 8 months ago

Thanks, I'll look at that send pull requests if it works, but from what I understand you won't update your plugin if you keep using Kimai2 v1.x ?

KatjaGlassConsulting commented 8 months ago

I will test whether it runs on both and I will maintain a second branch for v2.

KatjaGlassConsulting commented 7 months ago

Work is ongoing. Many thanks to Vitor. The branch is kimai_v2_update.

KatjaGlassConsulting commented 6 months ago

Thanks also to @sammaclennan for working on this issue as well. It's still buggy, but gets better and better.

vitormattos commented 6 months ago

Hi @KatjaGlassConsulting

Could you list the pending points to finish this issue? Maybe will help to receive contributions from other developers.

KatjaGlassConsulting commented 6 months ago

Hi @vitormattos, Kevin did directly a new PR to support the new kimai version. This PR will likely be merged soon. Can you probably already test that? Unluckily he didn't see the kimai_v2_update branch. Maybe I will also switch the main to Kimai v2 support and a new kimai_v1 branch.

Thanks to your support already and have great vacation days!

vitormattos commented 6 months ago

A best way to prevent this is to create a new branch from main called: stable1

Because stable1?

And maintain the branch main compatible to newest version of Kimai.

Every when launch a new big version of Kimai that break the Approval, we will need to create the next stable branch from main.

KatjaGlassConsulting commented 6 months ago

Thanks to all the supporter - version 2 support is now available on the main branch with the current Release as version 2.0.0. The version 1 support is available on the bundle_for_kimai_v1 branch with the current Release as version 1.0.0.