search

KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow
MIT License
11 stars 14 forks source link

Support Sunday as Start of Week #18

Closed tjpbwt closed 6 months ago

tjpbwt commented 11 months ago

Would it be possible to look into supporting Sunday as the work week start date? This would be helpful when all users are in the same time zone.

I'd be happy to try taking a look at this in my free time if I had a little context to any known technical issues that would break functionality if the work week was set to start on Sunday.

Thank you.

hsachan22 commented 11 months ago

Have you found any solution regarding this?

KatjaGlassConsulting commented 11 months ago

Hi, it would be possible to create a new option to have either only mondays or only sundays.

That could be implemented easily by adding this option and change all checks to that setting instead of Monday. Switching is tricky, there must be no approvals so far or all approved weeks will change the day.

I am in summer break and need to follow up other things. I would expect to implement this in autumn.

KatjaGlassConsulting commented 6 months ago

This topic is more tricky and for this I put this request unluckily "on-hold". There is the branch sundayWeekStart, but it is not working.

KatjaGlassConsulting commented 6 months ago

Due to complexity close this as not planned.

vitormattos commented 6 months ago

Maybe we can maintain as open and assign a label like 'backlog' or 'not planned' or anything else like this.