Kimai v2 latest

[vitormattos]

Follow my contribution to: https://github.com/KatjaGlassConsulting/ApprovalBundle/issues/17

Sorry by this big PR, but I'm trying to make working this plugin at my environment and I think that was necessary to run the follow changes. But I didn't put to work yet.

I did all commit separated, is possible to look more information at commits messages

[vitormattos]

The progress at this point:

Now is possible to run the follow command without errors:

bin/console kimai:reload --env=dev

[vitormattos]

Progress at this point:

Solved all errors when load plugins page

[vitormattos]

Pending:

Fix css issues about renamed classes at Kimai v2:

I think that now this PR is ready to be reviewed and merged

[KatjaGlassConsulting]

Hi Vitor, thanks for all your updates and a very special thank as having all single steps in single commits, which makes it easy for me to follow what changes happend why. I have merged all your requests to the branch "kimai_v2_update" - still additional updates are needed. It's currently not working on my windows Kimai 2 instance. Please feel free to work on this branch or update further. I will for now look into the API endpoints which are no longer working.

[vitormattos]

Thanks @KatjaGlassConsulting ! I'm follow doing the necessary to make working this plugin. I identified now a problem at frontend because have not Jquery at frontend. Maybe the easy will include the jquery.js file. I will close this PR as merged. Thanks for your consideration merging my contributions.

[vitormattos]

Could you explain more about this in an issue?

It's currently not working on my windows Kimai 2 instance.

[KatjaGlassConsulting]

Hi Vitor,

I am getting 500 errors ... I am checking with the API component from the demo bundle ... that is working, but not the APIs from the approval bundle.

[KatjaGlassConsulting]

This has to do with the parameter - looking into ApprovalNextWeekApiController.php:

When I remove the parameter definition it's working:

[OA\Parameter(

    name: 'user',
    in: 'query',
    type: 'integer',
    description: 'User ID to get information for',
    required: false,
)]

public function nextWeekAction(Request $request): Response

So I guess it must be defined differently.

[kevinpapst]

Sorry again for being so blind, that I missed all your hard work here @vitormattos

I really would have used it, but I just didn't check before starting my own branch. After migrating more than 10 plugins to v2, I just started hacking immediately, as I knew what to do. I think that is what you call job-blindness...

So sorry that I destroyed the community work 😢

[vitormattos]

@kevinpapst don't worry. My work was hidden in a uncommon branch. It's not a problem on either side and I increased my knowledge about this project and Kimai making my lost contribution.

A good learning about this is that open source projects need to have a good management and a flow to contributions.

I suggested here https://github.com/KatjaGlassConsulting/ApprovalBundle/issues/17#issuecomment-1869779369 a flow that could solve this problem. Maybe would be best to create an issue to make this discussion more easy to found by all and to be public.