Code and Docs improvements

KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow

MIT License

11 stars 14 forks source link

Closed kevinpapst closed 9 months ago

kevinpapst commented 9 months ago

Fixed several deprecations
Fixed PHPStan issues
and adapted the README to better reflect the Version 2, especially the fact that the user work hours are now configured in the core settings of the user and that the Custom-Fields plugin is not required anymore

kevinpapst commented 9 months ago

@KatjaGlassConsulting Please double-check the README, it contained infos that are no longer true for v2 (the custom-fields part).

I would recommend to add a prominent link that explains, that users of v1 MUST read the README from your other branch!

KatjaGlassConsulting commented 9 months ago

I prefere to have just one readme synced for both version - I will make some updates though, also in V1 the metaFields is optional.