KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow
MIT License
11 stars 14 forks source link

Tag names #31

Closed kevinpapst closed 8 months ago

kevinpapst commented 8 months ago

Hi Katja,

one request - not regarding the code: is there a reason you started adding the v to the tag names?

In the past the tag names only included the version itself.

Bildschirmfoto 2024-01-12 um 13 04 38

If you prefer the v, you could call the release v1.0.1 and the tag 1.0.1 ?

I stumbled upon it, while writing a bash script that use the versions from the store page, which don't mention the v:

Bildschirmfoto 2024-01-12 um 13 22 50
KatjaGlassConsulting commented 8 months ago

I will re-label it to without the v to support your bash script. There are just too many ways we can do things. No reason for this. It should be done by Monday at least.

kevinpapst commented 8 months ago

Don't change existing stuff, re-creating tags can cause weird issues. My wish was just for future 😄

Any yes, sometimes less options would be desirable.

kevinpapst commented 8 months ago

Closing, thanks Katja!

KatjaGlassConsulting commented 8 months ago

ok, so only for future releases I will work with no "v" tags and names.