"To Approve" tab needs white font color for dark theme

KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow

MIT License

11 stars 14 forks source link

"To Approve" tab needs white font color for dark theme #41

Closed brmeyer closed 3 months ago

brmeyer commented 3 months ago

Thank you for everything you do! We love Kimai!

I'm starting to experiment with this plugin and noticed the To Approve tab's data table doesn't appear to update for dark mode. The text is there (I'm highlighting one row). Is it a simple update to switch it to the white font? Happy to help with a contribution...

brmeyer commented 3 months ago

https://github.com/KatjaGlassConsulting/ApprovalBundle/pull/42 seems to fix it, simply removing the default bg-dark-lt from the status_color_class macro. Looks correct in Bright mode as well?

KatjaGlassConsulting commented 3 months ago

Thanks for the update, yes it's then working for dark and light theme. It will be merged soon.

KatjaGlassConsulting commented 3 months ago

Released in 2.0.4