[Bug] Link in email doesn't work

KatjaGlassConsulting / ApprovalBundle

A Kimai Plugin to manage weekly approval workflow

MIT License

11 stars 14 forks source link

[Bug] Link in email doesn't work #43

Closed kevinpapst closed 3 months ago

kevinpapst commented 3 months ago

Some emails (here at least the status change email for a rejected week) contain absolute path URLs, which the cannot be clicked.

See: https://github.com/KatjaGlassConsulting/ApprovalBundle/blob/main/Repository/ApprovalRepository.php#L710-L714

We need to replace UrlGeneratorInterface::ABSOLUTE_PATH with UrlGeneratorInterface::ABSOLUTE_PATH.

Who is willing to ship a PR to fix it?

KatjaGlassConsulting commented 3 months ago

Hi Kevin, the replacement is the same? Is there another value to use than UrlGeneratorInterface::ABSOLUTE_PATH?

kevinpapst commented 3 months ago

Hahaha, copy & paste... :blush:

ABSOLUTE_PATH should create something like /de/approval while
ABSOLUTE_URL should create something like https://www.example.com/de/approval

Maybe you can try it, I am in the middle of a feature branch, which I can't switch, so I can't test right now.

Oh an btw: someone reported that to me via email, saying that some links can't be clicked. I checked the code before posting and found this place, guessing that this might be the reason. I hope I am not entirely wrong here!

KatjaGlassConsulting commented 3 months ago

:) I will give it a try and update. :) Thanks

KatjaGlassConsulting commented 3 months ago

Corrected and released as 2.0.4