Closed kevinpapst closed 1 year ago
Oh wow! Thanks a lot! I am very busy the next three weeks, but I blocked the 17th October for detailed review and testing. I expect your PR to be included in October!
I know, I really sorry for that way too large PR... it's a burden, thanks for not closing it directly!
Have a look at this commit, it reduced the amount of DB queries in my dev system from ... well, see these screenshots:
Before:
After:
It is one of these small changes with a huge impact...
Thanks for merging 👍
Thanks for this excellent PR. :)
This is a huge PR, sorry for that!
It contains:
You could only use some commits if you prefer that.
First of all: I added a Github workflow to lint the entire codebase and prevent accidental code problems by using PHP-CS for code styles and phpstan for static code analysis.
I applied both tools, so big parts of the changes are "fixes".
With the changes from (2) anyone can now install the bundle and use it directly. People who want to check their working times can install the MetaField Bundle and configure the fields.
And please test it in detail, because my system has no MetaField setting for the working times. So I did not test that the refactoring did what I wanted... even though I expect that got it right .... but you never know 😁