Katona / zmk-ble

BLE utility app for ZMK based keyboards
MIT License
11 stars 3 forks source link

feature: make menu bar icon fit macos theme #1

Closed gaoDean closed 1 year ago

gaoDean commented 1 year ago

Most MacOS icons are background-transparent, so this commit removes the background of the icon svg and sets the image to be a template (so the colors can be reversed)

imo this shouldn't be squash merged because the first commit updates the Charts dependency so it works with xcode 14

alloc33 commented 1 year ago

@gaoDean How did you make it work?

I don't have anything in menu bar. Just running process in background:

Screenshot 2023-01-21 at 11 43 52 AM

Should I change something in my corne config maybe?

CONFIG_ZMK_KEYBOARD_NAME="Chocofi ZMK"
CONFIG_USB_DEVICE_VID=0x13BA
CONFIG_USB_DEVICE_PID=0x3E7
CONFIG_ZMK_BLE=y
CONFIG_BT=y
CONFIG_ZMK_IDLE_TIMEOUT=30000
CONFIG_ZMK_SLEEP=y
CONFIG_ZMK_IDLE_SLEEP_TIMEOUT=900000
CONFIG_ZMK_MOUSE=y
gaoDean commented 1 year ago

@xbladesub The app shouldn't depend on the keyboard working, when the keyboard is turned off, the app should still run in the background. Just to confirm cus I don't fully understand you, does the normal main branch work for you? Or is it just this version that doesn't show up?

gaoDean commented 1 year ago
Screenshot 2023-01-21 at 10 11 47 pm

Mine looks like this

alloc33 commented 1 year ago
Screenshot 2023-01-21 at 10 11 47 pm

Mine looks like this

I don't see menu bar item. (there is no zmk icon there, but process is running) I'm on macOS Ventura 13.1

gaoDean commented 1 year ago

Also check the Assets.xassets for the icon, see if it is not there or smth

gaoDean commented 1 year ago

I'm also on that version

gaoDean commented 1 year ago

Also are you on the latest Xcode?

alloc33 commented 1 year ago

Also are you on the latest Xcode?

yes, 14.2 for now

alloc33 commented 1 year ago

@gaoDean As you can see everything is ok with assets, app is running, but there is no icon in menu bar.

Screenshot 2023-01-21 at 10 07 47 PM
Katona commented 1 year ago

Merged, thanks! I think @xbladesub issues are independent of this change, we might try to address it in a different PR.

alloc33 commented 1 year ago

@Katona @gaoDean Solved, other apps didn't allow me to see menu bar item