search

KatrinaHoffert / EatSafe

An app for finding safe places to eat
Other
2 stars 2 forks source link

Hide defunct restaurants #107

Open KatrinaHoffert opened 9 years ago

KatrinaHoffert commented 9 years ago

Anything that hasn't been inspected in, say, 2 years (should be configurable) shouldn't be shown. Can be done at the model level. We only need to prevent them from being listed in the multi-map or location selection.

Issue: location selection isn't aware of inspections.

Possibility: create a "defunct" column in the DB and set this in the CSV parser, which is aware of the issues (parser could quickly look at all the inspection dates, sort them, grab the latest, and check if it meets some threshold).

KatrinaHoffert commented 9 years ago

I think this should be done in M5. It's not that hard to do. Issue is that we'd need to create more complicated queries and use caching. Or we could do what I mentioned in the post, which is a cleaner method. Still wouldn't be that hard, though.

I lean towards the CSV parser approach (a "defunct" column). It's more efficient without the need for caching.

Why is this important? Because we really want to avoid showing users locations that aren't there anymore. And a defunct column is more versatile because it could be set manually when some place closes (no current plans to do so, but it's more future proof).