search

KatrinaHoffert / EatSafe

An app for finding safe places to eat
Other
2 stars 2 forks source link

Pull JavaScript from displayCityMap.scala.html into external file #173

Closed Assisting closed 9 years ago

Assisting commented 9 years ago

It's sort of a mess as is. Could definitely be placed into a .js file to neaten up the template a bit.

magnusandy commented 9 years ago

gonna move to backburner as it is not critical

KatrinaHoffert commented 9 years ago

Moving this will improve performance by allowing caching. If nobody is currently working on the file, I'll do this now.

KatrinaHoffert commented 9 years ago

Never mind. Forgot about the Messages calls inside the JS. Rather not move it to its own file, now. Technically, we can have scripts that are templates, but now it's more trouble than it's worth to split. Would have to make routes and controllers for it. Meh.

Assisting commented 9 years ago

I'll add this to wontfix for now. We can possibly look at moving the non-Messages portions to an external file to improve caching. I'll probably have extra time to do it tomorrow, but if it breaks tests for some reason I won't bother committing the results.

KatrinaHoffert commented 9 years ago

Since this has been tagged as "wontfix", I'm closing it.