Kattis / problemtools

Tools to manage problem packages using the Kattis problem package format.
MIT License
101 stars 70 forks source link

Only AC submissions should have scores. #167

Closed ghamerly closed 4 years ago

ghamerly commented 4 years ago

Move the check for score after WA detection, so that WA does not get a score.

@simonlindholm do you have an opinion on this?

simonlindholm commented 4 years ago

+1 from me. Could simplify return SubmissionResult('WA', score=score, ... to just return SubmissionResult('WA', ....

ghamerly commented 4 years ago

Thanks @simonlindholm; I took your suggestion, and also changed a few more things (including one return value which I think was a bug -- returning a SubmissionResult object from grade() when a pair is expected).