search

Kattis / problemtools

Tools to manage problem packages using the Kattis problem package format.
MIT License
101 stars 70 forks source link

Add python type annotations to `problem2{html,pdf}` and `verifyproblem` #240

Closed JoelNiemela closed 7 months ago

JoelNiemela commented 8 months ago

Adds type annotations to problem2html.py, problem2pdf.py, and verifyproblem.py. Also modifies those files slightly, but the vast majority of changes are type annotations.

JoelNiemela commented 8 months ago

I would personally ignore the CodeFactor errors here, so I'll leave it as-is unless anyone else has a contrary opinion.

JoelNiemela commented 8 months ago

I would personally ignore the CodeFactor errors here, so I'll leave it as-is unless anyone else has a contrary opinion.

Instead of ignoring the warning that the code is breaking the currently defined rules, either fix it to follow the rules or suggest how the rules should be redefined.

I've had people disagree with me about this specific thing recently, so I think my opinion is more "controversial" than I thought, so I'll just change it to fix the CodeFactor errors.