Bugfix: safari on http does not persist cookie

KaufmannDigital / KaufmannDigital.GDPR.CookieConsent

A ready-to-run package, that integrates an advanced cookie consent banner into your Neos CMS site.

https://www.kaufmann.digital/neos-cms/plugins/dsgvo-gdpr-cookie-consent

GNU General Public License v3.0

26 stars 11 forks source link

Bugfix: safari on http does not persist cookie #31

Closed hphoeksma closed 2 years ago

hphoeksma commented 2 years ago

Safari on HTTP does not persist a cookie when set to secure.

Ran into this during local development.

hphoeksma commented 2 years ago

Its better when you use location.protocol.substring(0,5) === 'https', cause location.protocol has the value https: or http: and there is a Bug in Firefox right now.

Done, thnx for the heads up.

Nikdro commented 2 years ago

Thank you very much @markuspfeifenberger and @hphoeksma! I'll also have a look on it today/tomorrow and create a new version out of it. But looking good from the first view.

Nikdro commented 2 years ago

Thank again @markuspfeifenberger and @hphoeksma! Sorry for the late response!

This Bugfix is now available in Version 4.1.1, 4.0.15, 3.3.5 and in an adapted version also in 2.2.8