BUGFIX: adjust conditions to prevent double insert of script

KaufmannDigital / KaufmannDigital.GDPR.CookieConsent

A ready-to-run package, that integrates an advanced cookie consent banner into your Neos CMS site.

https://www.kaufmann.digital/neos-cms/plugins/dsgvo-gdpr-cookie-consent

GNU General Public License v3.0

26 stars 11 forks source link

BUGFIX: adjust conditions to prevent double insert of script #53

Closed andrehoffmann30 closed 10 months ago

andrehoffmann30 commented 10 months ago

These adjustments prevent the api from being requested twice for querying the configured javascript. Currently, when using the gdpr query parameter with the accept-all value, an empty cache entry may be generated on the server side due to the duplicate call and thus no tracking code is downloaded. By adjusting the call conditions in the javascript, a mistakenly triggered api call is avoided and as far as I can see, the tracking javascript code is fetched correctly.

Nikdro commented 10 months ago

Thanks for you PR :) Merged and released with 5.2.0