TASK: Initialize.js makes loadCookiebannerHtml parameters explicit

KaufmannDigital / KaufmannDigital.GDPR.CookieConsent

A ready-to-run package, that integrates an advanced cookie consent banner into your Neos CMS site.

https://www.kaufmann.digital/neos-cms/plugins/dsgvo-gdpr-cookie-consent

GNU General Public License v3.0

26 stars 11 forks source link

TASK: Initialize.js makes loadCookiebannerHtml parameters explicit #59

Closed gjwnc closed 4 months ago

gjwnc commented 4 months ago

The feature hideBeforeInteraction does not work, because, currently, the parameters for loadCookiebannerHtml are used in strict equality comparision, e.g. here, but most of the time, no parameters are given at all, which causes the comparision to fail, because undefined !== false.
This PR set the parameters for loadCookiebannerHtml explicit to false causing hideBeforeInteraction to function correctly.

Nikdro commented 4 months ago

Thank you very much, again! This is now available in Version 5.4.0 and will be down-merged into other supported versions.