Duplicate Code - Githubissues

Kautenja / PotatoChips

Eurorack modules based on programmable sound chip emulation.

Other

45 stars 4 forks source link

Duplicate Code #45

Closed Kautenja closed 3 years ago

Kautenja commented 3 years ago

there is a lot of duplicate code that can be reduced to global functions.

[x] getAudioOut
[x] onSampleRateChange
[x] constructors that initialize APUs and BLIPBuffers
[ ] frequency, period, and volume parameter converters
- many of these can move to static functions within the chip emulator class
[x] polyphony loops

Kautenja commented 3 years ago

A super class has been developed, ChipModule, that addresses the redundancy of constructors, onSampleRateChange, and some aspects of polyphonic loops. More can be generalized if the VU meters are removed from the modules that currently use them.