search

Kautenja / PotatoChips

Eurorack modules based on programmable sound chip emulation.
Other
44 stars 4 forks source link

2612 initializes with noise sometimes #52

Closed Kautenja closed 4 years ago

Kautenja commented 4 years ago

Describe the bug

Some of the oscillator voices on 2612 are initialized in a state that produces noise when there should be none.

To Reproduce

Steps to reproduce the behavior:

  1. initialize a 2612
  2. mess around with gates in polyphonic mode to try to find a noisy voice

Expected behavior

Voices do not produce undue noise (without being parameterized to be noisy), i.e., the default patch should always sound the same, but sometimes a voice has noise in it.

Kautenja commented 4 years ago

I think this was the result of using structures that hadn't set initial values to 0 where necessary. Specifically, I believe the feedback parameter in the structures was being initialized to a non-deterministic value from memory and falling into a logical fault. Setting structures to 0 on initialization seems to have resolved the issue.