[Feature] Add typing - Githubissues

Kautenja / gym-super-mario-bros

An OpenAI Gym interface to Super Mario Bros. & Super Mario Bros. 2 (Lost Levels) on The NES

Other

678 stars 133 forks source link

[Feature] Add typing #103

Closed ganyariya closed 3 years ago

ganyariya commented 3 years ago

Description

This PR adds typing to gym-super-mario-bros in import part, smb_env.py.

I feel that this repository supports 3.5 - 3.9, so I use List, Tuple as typing.

Type of change

Please select all relevant options:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] MGMT (non-breaking change to deployment, CI, etc.

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works

Kautenja commented 3 years ago

Thanks for the PR! Unfortunately, this seems to break backwards compatibility with all versions of Python other than 3.9 (https://app.travis-ci.com/github/Kautenja/gym-super-mario-bros/builds/236973098). Because support of python 3.5-3.9 is necessary for this project, this PR cannot be merged at this time.