Kautenja / gym-super-mario-bros

An OpenAI Gym interface to Super Mario Bros. & Super Mario Bros. 2 (Lost Levels) on The NES
Other
678 stars 133 forks source link

[Feature] Add the number of killed enemies to info object #104

Closed ganyariya closed 3 years ago

ganyariya commented 3 years ago

Description

This PR add the number of killed enemies into info object. For example, mario kills 3 goomba, then info["kills"] = 3.

Pros and Cons

Notes

This PR is based on #103 .

This PR is not need and not important for this gym-super-mario-bros ! So, If you feel that this PR is not important for gym-super-mario-bros, please close this :)

Type of change

Please select all relevant options:

Checklist

Kautenja commented 3 years ago

Thanks for the PR! Unfortunately, this seems to break backwards compatibility with all versions of Python other than 3.9 (https://app.travis-ci.com/github/Kautenja/gym-super-mario-bros/builds/236973112). Because support of python 3.5-3.9 is necessary for this project, this PR cannot be merged at this time. I'm happy to consider the killed enemies feature if you put together a new PR without the type hints.