Kautenja / gym-super-mario-bros

An OpenAI Gym interface to Super Mario Bros. & Super Mario Bros. 2 (Lost Levels) on The NES
Other
678 stars 133 forks source link

RuntimeWarning: overflow encountered in ubyte_scalars in smb_env.py:149 #98

Closed Neqit closed 4 years ago

Neqit commented 4 years ago

Describe the bug

During learning process, program keep spamming this message:

C:\Users\User\anaconda3\envs\mario\lib\site-packages\gym_super_mario_bros\smb_env.py:151: RuntimeWarning: overflow encountered in ubyte_scalars return (self.ram[0x86] - self.ram[0x071c]) % 256

Expected behavior

Message about overflow encountered in ubyte_scalars should't spam

Screenshots

here is the screenshot with condition of spam: image

and here is the meaning of the other numbers in smb_env.py image

Additional context

Tried to check if variables self.ram[0x86] and self.ram[0x071c], or their subtraction, become > 255. but didn't find anything strange. The only thing that i noticed, that this message keeps spamming only if I use DDQN algorithm instead of basic DQN

Kautenja commented 4 years ago

this is a duplicate of #94, which i believe to be resolved. please try updating to the latest version and let me know if the problem still occurs. thanks!

Neqit commented 4 years ago

Sorry for duplicate. Thanks!