Kautenja / nes-py

A Python3 NES emulator and OpenAI Gym interface
MIT License
235 stars 63 forks source link

fixed new gym API related to step() and reset() #87

Open spyroot opened 1 year ago

spyroot commented 1 year ago

Description

There are several issues related to changes in API. I re-adjusted all code, so it returned truncated in step and readjusted reset to match what the gym expected. In parallel, fixed Mario env. Note old code won't work with this since GYM now return five elements in a tuple vs. 4. Same for reset. I also re-adjusted all the unit tests and examples, so it matched and passed all tests.

Type of change

Please select all relevant options:

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration

Checklist

alrdebugne commented 1 year ago

Any reason why this shouldn't be merged with the suggested edits?